Re: Issues with getting the timers right
Posted: Fri Jan 02, 2015 12:02 pm
OK, I would tend to not disable/enable the whole Virtual Combat key map, but rather enable/disable the Virtual Combat -> DPS Rotation mapped key. Use a Mapped Key State Action, not a Key Map State action.
Well, you do reset all back to step 1 and enabled, but you don't reset all timers or make sure that the Virtual Combat keymap is re-enabled (and this is a problem). This kind of means that your Assist keypress doesn't always make it through when you hit your assist hot key if the Virtual Combat keymap is not currently enabled. This comes back to, you shouldn't disable the Virtual Combat key map as I said above.
I can't see anything else out of the ordinary, it seems to be fairly good.
In IsBoxer, I re-enable ALL steps, and cancel all timers when that same key is pressed.
Well, you do reset all back to step 1 and enabled, but you don't reset all timers or make sure that the Virtual Combat keymap is re-enabled (and this is a problem). This kind of means that your Assist keypress doesn't always make it through when you hit your assist hot key if the Virtual Combat keymap is not currently enabled. This comes back to, you shouldn't disable the Virtual Combat key map as I said above.
I can't see anything else out of the ordinary, it seems to be fairly good.